From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Douglas Doole <dougdoole(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Collation versioning |
Date: | 2020-07-08 06:12:51 |
Message-ID: | CA+hUKGLrSHedEs=xgHxto6twnacbSZtC_rdZL+=Uv8jkPm1boA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 2, 2020 at 3:03 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> And the recent ObjectAddress refactoring just broke the patchset again, so v25
> attached.
I found some more things to remove from pg_dump.c and collationcmds.c
relating pg_collation.collversion. I also updated a couple of
mentions of release 13 in the code and docs, and made some minor
language improvements here and there.
I still wish I had a better idea than this:
+/*
+ * Returns whether the given index access method depend on a stable collation
+ * order.
+ */
+static bool
+index_depends_stable_coll_order(Oid amoid)
+{
+ return (amoid != HASH_AM_OID &&
+ strcmp(get_am_name(amoid), "bloom") != 0);
+}
I'm doing some more testing and looking for weird cases... More soon.
Attachment | Content-Type | Size |
---|---|---|
v26-0001-Remove-pg_collation.collversion.patch | text/x-patch | 27.7 KB |
v26-0002-Add-pg_depend.refobjversion.patch | text/x-patch | 12.3 KB |
v26-0003-Track-collation-versions-for-indexes.patch | text/x-patch | 106.4 KB |
v26-0004-Add-ALTER-INDEX-.-ALTER-COLLATION-.-REFRESH-VERS.patch | text/x-patch | 14.8 KB |
v26-0005-Doc-Add-Collation-Versions-section.patch | text/x-patch | 2.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-07-08 06:19:34 | Re: Performing partition pruning using row value |
Previous Message | Michael Paquier | 2020-07-08 06:08:24 | Re: A patch for get origin from commit_ts. |