Re: [PATCH] remove pg_standby

On Wed, Jan 27, 2021 at 6:06 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jan 27, 2021 at 04:13:24PM +1300, Thomas Munro wrote:
> > I would like to commit this, because "waiting restore commands" have
> > confusing interactions with my proposed prefetching-during-recovery
> > patch[1]. Here's a version that fixes an error when building the docs
> > (there was a stray remaining <xref linkend="pgstandby"/>), and adds a
> > commit message. Any objections?
>
> It looks like you are missing two references in your patch set:
> $ git grep pg_standby
> doc/src/sgml/high-availability.sgml: Do not use pg_standby or
> similar tools with the built-in standby mode
> src/backend/access/transam/xlog.c: * segment. Only recycle normal
> files, pg_standby for example can create

Thanks, fixed.

> The logic assumed in RemoveXlogFile() is actually a bit scary. I have
> not checked in details but it could be possible to clean up more code
> in this area?

I think the check that it's a regular file is a good idea anyway, but
I removed the offending comment.

> > Furthermore, I think we should also remove the section of the manual
> > that describes how to write your own "waiting restore command".
> > Thoughts?
>
> Agreed. No objections to that.

Thanks!