| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, samay sharma <smilingsamay(at)gmail(dot)com> |
| Subject: | Re: CI and test improvements |
| Date: | 2022-12-30 03:59:03 |
| Message-ID: | CA+hUKGL=z6-kU80nPTjWqV=Xo=mpM36Lca=ngTr4LqcCf=tHzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 23, 2022 at 11:57 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> [PATCH 02/10] cirrus/macos: switch to "macos_instance" / M1..
Duelling patches.
Bilal's patch[1] uses the matrix feature to run the tests on both
Intel and ARM, which made sense when he proposed it, but according to
Cirrus CI warnings, the Intel instances are about to go away. So I
think we just need your smaller change to switch the instance type.
As for the pathname change, there is another place that knows where
Homebrew lives, in ldap/001_auth. Fixed in the attached. That test
just SKIPs if it can't find the binary, making it harder to notice.
Standardising our approach here might make sense for a later patch.
As for the kerberos test, Bilal's patch may well be a better idea (it
adds MacPorts for one thing), and so I'll suggest rebasing that, but
here I just wanted the minimum mechanical fix to avoid breaking on the
1st of Jan.
I plan to push this soon if there are no objections. Then discussion
of Bilal's patch can continue.
> [PATCH 03/10] cirrus/macos: update to macos ventura
I don't know any reason not to push this one too, but it's not time critical.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-ci-Change-macOS-builds-from-Intel-to-ARM.patch | text/x-patch | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-12-30 05:21:22 | Re: Getting rid of SQLValueFunction |
| Previous Message | Peter Geoghegan | 2022-12-30 03:01:35 | Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation |