From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Requiring LLVM 14+ in PostgreSQL 18 |
Date: | 2024-05-15 04:21:25 |
Message-ID: | CA+hUKGL3EJ37xuj0813AfgwtxBSmfM_pwE8pSGGE5BeKSxCiZw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, May 13, 2024 at 2:33 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> These patches look fine to me. The new cut-off makes sense, and it does
> save quite a bit of code. We do need to get the Cirrus CI Debian images
> updated first, as you had already written.
Thanks for looking!
> As part of this patch, you also sneak in support for LLVM 18
> (llvm-config-18, clang-18 in configure). Should this be a separate patch?
Yeah, right, I didn't really think too hard about why we have that,
and now that you question it...
> And as I'm looking up how this was previously handled, I notice that
> this list of clang-NN versions was last updated equally sneakily as part
> of your patch to trim off LLVM <10 (820b5af73dc). I wonder if the
> original intention of that configure code was that maintaining the
> versioned list above clang-7/llvm-config-7 was not needed, because the
> unversioning programs could be used, or maybe because pkg-config could
> be used. It would be nice if we could get rid of having to update that.
I probably misunderstood why we were doing that, perhaps something to
do with the way some distro (Debian?) was doing things with older
versions, and yeah I see that we went a long time after 7 without
touching it and nobody cared. Yeah, it would be nice to get rid of
it. Here's a patch. Meson didn't have that.
Attachment | Content-Type | Size |
---|---|---|
v3-0001-jit-Remove-configure-probes-for-lvm-config-clang-.patch | text/x-patch | 2.7 KB |
v3-0002-jit-Require-at-least-LLVM-14-if-enabled.patch | text/x-patch | 14.3 KB |
v3-0003-jit-Use-opaque-pointers-in-all-supported-LLVM-ver.patch | text/x-patch | 8.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-05-15 04:27:10 | Re: Underscore in positional parameters? |
Previous Message | Michael Paquier | 2024-05-15 03:55:56 | Re: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled |