From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Date: | 2022-03-29 19:30:27 |
Message-ID: | CA+hUKGK_J2XmrhVToBfnhnAaQVP0r5C1b6ae5Kc15cSQNMgdWw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 30, 2022 at 3:08 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Mar 25, 2022 at 5:52 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > On Sat, Mar 26, 2022 at 9:55 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > This line doesn't look too healthy:
> >
> > pg_basebackup: error: backup failed: ERROR: shell command "type con >
> > "C:cirruscontrib asebackup_to_shell mp_check mp_test_tch3\base.tar""
> > failed
> >
> > I guess it's an escaping problem around \ characters.
>
> Oh, right. I didn't copy the usual incantation as completely as I
> should have done.
>
> Here's a new version, hopefully rectifying that deficiency. I also add
> a second patch here, documenting basebackup_to_shell.required_role,
> because Joe Conway observed elsewhere that I forgot to do that.
Here are your patches again, plus that kludge to make the CI run your
TAP test on Windows.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-basebackup_to_shell-Add-TAP-test.patch | text/x-patch | 5.2 KB |
v2-0002-Document-basebackup_to_shell.required_role.patch | text/x-patch | 1.3 KB |
0002-HACK-run-tap-tests-in-contrib-basebackup_to_shell.patch | text/x-patch | 825 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-03-29 20:35:31 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Previous Message | Robert Haas | 2022-03-29 17:52:27 | pgsql: In 020_createdb.pl, change order of command-line arguments. |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2022-03-29 20:05:44 | Re: Add parameter jit_warn_above_fraction |
Previous Message | Robert Haas | 2022-03-29 19:20:17 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |