| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cannot find a working 64-bit integer type on Illumos |
| Date: | 2024-04-18 20:29:27 |
| Message-ID: | CA+hUKGKXEdVSfR6UHXfR3tSQ+TfBNk-ssYmO2F0wCdw7qcx86Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 18, 2024 at 8:47 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> I'm not sure I understand the problem here. Do you mean that in theory
> a platform's PRId64 could be something other than "l" or "ll"?
Yes. I don't know why anyone would do that, and the systems I checked
all have the obvious definitions, eg "ld", "lld" etc. Perhaps it's an
acceptable risk? It certainly gives us a tidier result.
For discussion, here is a variant that fully embraces <inttypes.h> and
the PRI*64 macros.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Use-int64_t-support-from-stdint.h-and-inttypes.h.patch | application/octet-stream | 38.2 KB |
| v2-0002-Remove-traces-of-BeOS.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-04-18 20:33:08 | Re: improve performance of pg_dump --binary-upgrade |
| Previous Message | Nathan Bossart | 2024-04-18 20:28:13 | Re: improve performance of pg_dump --binary-upgrade |