From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: gai_strerror() is not thread-safe on Windows |
Date: | 2024-02-11 22:25:53 |
Message-ID: | CA+hUKGKJrWAwptmgQC7VELg2u+-Sh4kSxJ=_x=dtZkHCO+KOGA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 16, 2024 at 8:52 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Dec 6, 2023 at 8:45 PM Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > > So I think we should just hard-code the error messages in English and
> > > move on. However, English is my language so perhaps I should abstain
> > > and leave it to others to decide how important that is.
> >
> > I also think that would be a good way.
>
> Considering this remark from Kyotaro Horiguchi, I think the
> previously-posted patch could be committed.
>
> Thomas, do you plan to do that, or are there outstanding issues here?
Pushed. I went with FreeBSD's error messages (I assume it'd be OK to
take glibc's too under fair use but I didn't want to think about
that).
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-02-11 23:09:32 | Re: make dist using git archive |
Previous Message | Tom Lane | 2024-02-11 21:42:44 | Re: Catalog domain not-null constraints |