From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parallel Full Hash Join |
Date: | 2022-04-08 11:29:32 |
Message-ID: | CA+hUKGJ_k86BdZudXQchr0q+rpF1KqaZRsoX0GhN0c+uCO8q6g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 12, 2022 at 10:30 AM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
> On Fri, Nov 26, 2021 at 3:11 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > #3 0x00000000009cf57e in ExceptionalCondition (conditionName=0x29cae8
> > "BarrierParticipants(&accessor->shared->batch_barrier) == 1",
> > errorType=<optimized out>, fileName=0x2ae561 "nodeHash.c",
> > lineNumber=lineNumber(at)entry=2224) at assert.c:69
> > No locals.
> > #4 0x000000000071575e in ExecParallelScanHashTableForUnmatched
> > (hjstate=hjstate(at)entry=0x80a60a3c8,
> > econtext=econtext(at)entry=0x80a60ae98) at nodeHash.c:2224
>
> I believe this assert can be safely removed.
Agreed.
I was looking at this with a view to committing it, but I need more
time. This will be at the front of my queue when the tree reopens.
I'm trying to find the tooling I had somewhere that could let you test
attaching and detaching at every phase.
The attached version is just pgindent'd.
Attachment | Content-Type | Size |
---|---|---|
v11-0001-Fix-race-condition-in-parallel-hash-join-batch-c.patch | text/x-patch | 11.3 KB |
v11-0002-Improve-the-naming-of-Parallel-Hash-Join-phases.patch | text/x-patch | 25.6 KB |
v11-0003-Parallel-Hash-Full-Right-Outer-Join.patch | text/x-patch | 26.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2022-04-08 11:32:44 | Re: Add parameter jit_warn_above_fraction |
Previous Message | Magnus Hagander | 2022-04-08 11:27:06 | Re: Add parameter jit_warn_above_fraction |