From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal - psql - use pager for \watch command |
Date: | 2021-03-22 23:35:09 |
Message-ID: | CA+hUKG+E3VfG0ZUi3UAJfVUNjp3sNFo89Ai8U9EgC+qwX8yr4A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Mar 21, 2021 at 11:43 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> so 20. 3. 2021 v 23:45 odesílatel Thomas Munro <thomas(dot)munro(at)gmail(dot)com> napsal:
>> Thoughts? I put my changes into a separate patch for clarity, but
>> they need some more tidying up.
>
> yes, your solution is much better.
Hmm, there was a problem with it though: it blocked ^C while running
the query, which is bad. I fixed that. I did some polishing of the
code and some editing on the documentation and comments. I disabled
the feature completely on Windows, because it seems unlikely that
we'll be able to know if it even works, in this cycle.
- output = PageOutput(158, pager ? &(pset.popt.topt) : NULL);
+ output = PageOutput(160, pager ? &(pset.popt.topt) : NULL);
What is that change for?
Attachment | Content-Type | Size |
---|---|---|
v4-0001-Add-PSQL_WATCH_PAGER-for-psql-s-watch-command.patch | text/x-patch | 12.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-03-22 23:38:50 | Re: Support for NSS as a libpq TLS backend |
Previous Message | Jan Wieck | 2021-03-22 23:18:33 | Re: pg_upgrade failing for 200+ million Large Objects |