| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Mahendra Singh <mahi6run(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Steele <david(at)pgmasters(dot)net>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Block level parallel vacuum |
| Date: | 2019-12-20 06:43:22 |
| Message-ID: | CA+fd4k6h1+Tj6n=iYiXLPx509fM8bTfFvEMNERd_NzKVnW6iGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 19 Dec 2019 at 22:48, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Dec 19, 2019 at 12:41 AM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> > Attached the updated version patch. This version patch incorporates
> > the above comments and the comments from Mahendra. I also fixed one
> > bug around determining the indexes that are vacuumed in parallel based
> > on their option and size. Please review it.
>
> I'm not enthusiastic about the fact that 0003 calls the fast option
> 'disable_delay' in some places. I think it would be more clear to call
> it 'fast' everywhere.
>
Agreed.
I've attached the updated version patch that incorporated the all
review comments I go so far.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v38-0003-Add-FAST-option-to-vacuum-command.patch | application/octet-stream | 9.8 KB |
| v38-0001-Add-index-AM-field-and-callback-for-parallel-ind.patch | application/octet-stream | 10.1 KB |
| v38-0002-Add-parallel-option-to-VACUUM-command.patch | application/octet-stream | 75.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2019-12-20 07:12:23 | RE: Implementing Incremental View Maintenance |
| Previous Message | Masahiko Sawada | 2019-12-20 06:17:08 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |