| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [POC] A better way to expand hash indexes. |
| Date: | 2017-04-04 11:45:21 |
| Message-ID: | CA+TgmobeEhUvA_G7L0uUgUkxEz_UYimx_5TjCMMyvzucEP-iGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 4, 2017 at 6:33 AM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> wrote:
> On Tue, Apr 4, 2017 at 9:18 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Committed.
>
> Thanks Robert,
>
> And also sorry, one unfortunate thing happened in the last patch while
> fixing one of the review comments a variable disappeared from the
> equation
> @_hash_spareindex.
>
> splitpoint_phases +=
> - (((num_bucket - 1) >> (HASH_SPLITPOINT_PHASE_BITS + 1)) &
> + (((num_bucket - 1) >>
> + (splitpoint_group - (HASH_SPLITPOINT_PHASE_BITS + 1))) &
> HASH_SPLITPOINT_PHASE_MASK); /* to 0-based value. */
>
> I wanted most significant 3 bits. And while fixing comments in patch11
> I unknowingly somehow removed splitpoint_group from the equation.
> Extremely sorry for the mistake. Thanks to Ashutosh Sharma for
> pointing the mistake.
Ugh, OK, committed that also. Please try to be more careful in the future.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-04 11:57:03 | Re: Page Scan Mode in Hash Index |
| Previous Message | Masahiko Sawada | 2017-04-04 11:29:38 | Re: show "aggressive" or not in autovacuum logs |