Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-29 14:08:03
Message-ID: CA+Tgmoat+zbzzZQJ7poXyUwiqxQxTaUid=auB4FejZ15VvDh4Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Mar 25, 2022 at 5:52 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sat, Mar 26, 2022 at 9:55 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > https://api.cirrus-ci.com/v1/artifact/task/5637156969381888/log/contrib/basebackup_to_shell/tmp_check/log/regress_log_001_basic
>
> This line doesn't look too healthy:
>
> pg_basebackup: error: backup failed: ERROR: shell command "type con >
> "C:cirruscontrib asebackup_to_shell mp_check mp_test_tch3\base.tar""
> failed
>
> I guess it's an escaping problem around \ characters.

Oh, right. I didn't copy the usual incantation as completely as I
should have done.

Here's a new version, hopefully rectifying that deficiency. I also add
a second patch here, documenting basebackup_to_shell.required_role,
because Joe Conway observed elsewhere that I forgot to do that.

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v2-0002-Document-basebackup_to_shell.required_role.patch application/octet-stream 1.3 KB
v2-0001-basebackup_to_shell-Add-TAP-test.patch application/octet-stream 5.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-03-29 14:36:17 pgsql: Revert "Fix replay of create database records on standby"
Previous Message Robert Haas 2022-03-29 13:30:20 pgsql: Explain why the startup process can't cause a shortage of sinval

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2022-03-29 14:20:37 Restructure ALTER TABLE notes to clarify table rewrites and verification scans
Previous Message James Coleman 2022-03-29 14:03:45 Correct docs re: rewriting indexes when table rewrite is skipped