From: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
---|---|
To: | Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> |
Cc: | Cary Huang <cary(dot)huang(at)highgo(dot)ca>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Allow Postgres to pick an unused port to listen |
Date: | 2023-05-11 06:46:30 |
Message-ID: | CA+RLCQy1pzWM9TQVgUmDOtV947k05XpTLMaXcgAU8T-VUd+h_A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Denis,
Great catch. I've amended the patch to fix this issue with the
documentation (V3).
On Tue, May 9, 2023 at 2:25 PM Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com>
wrote:
> The documentation fails to build for me:
>
> $ ninja docs
> [1/2] Generating doc/src/sgml/postgres-full.xml with a custom command
> FAILED: doc/src/sgml/postgres-full.xml
> /usr/bin/python3 ../postgresql/doc/src/sgml/xmltools_dep_wrapper
> --targetname doc/src/sgml/postgres-full.xml --depfile
> doc/src/sgml/postgres-full.xml.d --tool /usr/bin/xmllint -- --nonet
> --noent --valid --path doc/src/sgml -o doc/src/sgml/postgres-full.xml
> ../postgresql/doc/src/sgml/postgres.sgml
> ../postgresql/doc/src/sgml/postgres.sgml:685: element para: validity
> error : Element entry is not declared in para list of possible children
> ninja: build stopped: subcommand failed.
>
>
> Removing the <entry> tag resolves the issue:
> diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
> index cd07bad3b5..f71859f710 100644
> --- a/doc/src/sgml/config.sgml
> +++ b/doc/src/sgml/config.sgml
> @@ -684,7 +684,7 @@ include_dir 'conf.d'
> </para>
> <para>
> The port can be set to 0 to make Postgres pick an unused port
> number.
> - The assigned port number can be then retrieved from
> <entry><filename>postmaster.pid</filename></entry>.
> + The assigned port number can be then retrieved from
> <filename>postmaster.pid</filename>.
> </para>
> </listitem>
> </varlistentry>
>
>
--
Y.
Attachment | Content-Type | Size |
---|---|---|
V3-0001-Allow-listening-port-to-be-0.patch | application/octet-stream | 8.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Yurii Rashkovskii | 2023-05-11 07:01:37 | Re: [PATCH] Allow Postgres to pick an unused port to listen |
Previous Message | Hayato Kuroda (Fujitsu) | 2023-05-11 06:35:21 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |