From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Monitoring roles patch |
Date: | 2017-03-23 10:41:47 |
Message-ID: | CA+OCxozGTGd-x+cx03N=KJVK=soJwOpTWkq_=zac3P04aBCU4Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 22, 2017 at 3:46 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Wed, Mar 22, 2017 at 1:15 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>>
>> I did specifically ask for explicit roles to be made to enable such
>> capability and that the pg_monitor role be GRANT'd those roles instead
>> of hacking the pg_monitor OID into those checks, but it seems like
>> that's not been done yet.
>
> Yeah, sorry - I missed that for pg_stat_activity. I'll update the patch.
Updated patch attached. This changes pg_read_all_gucs to
pg_read_all_settings, and adds pg_read_all_stats which it grants to
pg_monitor. pg_read_all_stats has full access to the pg_stat_ views
(as pg_monitor did previously), and is used in the various contrib
modules in place of pg_monitor.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
pg_monitor_v3.diff | text/plain | 25.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Karlsson | 2017-03-23 10:45:12 | Re: Refactor handling of database attributes between pg_dump and pg_dumpall |
Previous Message | Daniel Gustafsson | 2017-03-23 10:41:38 | Re: createlang/droplang deprecated |