From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, yuzuko <yuzukohosoya(at)gmail(dot)com>, shawn wang <shawn(dot)wang(dot)pg(at)gmail(dot)com>, Shawn Wang <shawn(dot)wang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Problem with default partition pruning |
Date: | 2019-08-09 04:17:41 |
Message-ID: | CA+HiwqHDaxHyCHNY7d7nzDFBrNAFzUUfcb=db1DeT_-J1GsfGQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Horiguchi-san,
Thanks for the review.
On Fri, Aug 9, 2019 at 12:09 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> At Thu, 8 Aug 2019 14:50:54 +0900, Amit Langote wrote:
> > When working on it, I realized
> > that the way RelOptInfo.partition_qual is processed is a bit
> > duplicative, so I created a separate patch to make that a bit more
> > consistent.
>
> 0001 seems reasonable. By the way, the patch doesn't touch
> get_relation_constraints(), but I suppose it can use the modified
> partition constraint qual already stored in rel->partition_qual
> in set_relation_partition_info. And we could move constifying to
> set_rlation_partition_info?
Ah, good advice. This make partition constraint usage within the
planner quite a bit more consistent.
> Also, I'd like to see comments that the partition_quals is
> already varnode-fixed.
Added a one-line comment.
> And 0002, yeah, just +1 from me.
Thanks.
Attached updated patches; only 0001 changed per above comments.
Regards,
Amit
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Improve-RelOptInfo.partition_qual-usage.patch | application/octet-stream | 5.5 KB |
v2-0002-Improve-constraint-exclusion-usage-in-partprune.c.patch | application/octet-stream | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-08-09 04:34:56 | Re: Regression test failure in regression test temp.sql |
Previous Message | Amit Kapila | 2019-08-09 04:14:36 | Re: POC: Cleaning up orphaned files using undo logs |