From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: ExecRTCheckPerms() and many prunable partitions |
Date: | 2022-03-14 07:36:53 |
Message-ID: | CA+HiwqH2dRjEepJih7tBYb3XbhTeemEaL6jue6gxKT_vbk+sLg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 18, 2022 at 12:42 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Hi,
> For patch 02, in the description:
Thanks for looking.
> present for locking views during execition
>
> Typo: execution.
>
> + * to be used by the executor to lock the view relation and for the
> + * planner to be able to record the view relation OID in the PlannedStmt
> + * that it produces for the query.
>
> I think the sentence about executor can be placed after the sentence for the planner.
Fixed.
> For patch 01, GetRelPermissionInfo():
>
> + return perminfo;
> + }
> + else
>
> keyword 'else' is not needed - the else block can be left-indented.
OK, done.
Also needed fixes when rebasing.
--
Amit Langote
EDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
v9-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-rul.patch | application/octet-stream | 116.2 KB |
v9-0001-Rework-query-relation-permission-checking.patch | application/octet-stream | 151.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2022-03-14 08:02:10 | Re: Issue with pg_stat_subscription_stats |
Previous Message | Julien Rouhaud | 2022-03-14 07:17:13 | Re: WIP: WAL prefetch (another approach) |