From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Subject: | Re: Making Bitmapsets be valid Nodes |
Date: | 2022-11-14 07:26:07 |
Message-ID: | CA+HiwqGwimkH4bBJHHKqDWOY_MrROiy8_XKiEVMN+OJ1OTb2Rg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Nov 14, 2022 at 12:23 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> > On 11.11.22 21:05, Tom Lane wrote:
> >> Attached is a cleaned-up version of Amit's patch v24-0003 at [2].
> >> I fixed the problems with not always tagging Bitmapsets, and changed
> >> the outfuncs/readfuncs logic so that Bitmapsets still print exactly
> >> as they did before (thus, this doesn't require a catversion bump).
>
> > This looks good to me.
>
> Pushed, thanks for looking.
Thanks a lot for this.
I agree that it may not be worthwhile to add an extra function call by
changing COPY_BITMAPSET_FIELD, etc. that is currently emitted by
gen_node_support.pl for any Bitmapset * / Relid struct members to
COPY_NODE_FIELD, etc.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2022-11-14 07:32:43 | Re: ExecRTCheckPerms() and many prunable partitions |
Previous Message | John Naylor | 2022-11-14 07:25:30 | Re: Non-decimal integer literals |