From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Richard Guo <riguo(at)pivotal(dot)io>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: d25ea01275 and partitionwise join |
Date: | 2019-11-06 09:40:09 |
Message-ID: | CA+HiwqEJ+dn0O6Qmq6AM_nt3aQPdJp+rLc9XJ9WfT2KFXO0+kQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 6, 2019 at 2:00 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> > On Mon, Oct 14, 2019 at 5:02 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >> I can't say much about the patch; there's a little typo:
> >> "The nullability of inner relation keys prevents them to"
> >> ..should say "prevent them from".
>
> > Thanks, will fix.
>
> Just to leave a breadcrumb in this thread --- the planner failure
> induced by d25ea01275 has been fixed in 529ebb20a. The difficulty
> with multiway full joins that Amit started this thread with remains
> open, but I imagine the posted patches will need rebasing over
> 529ebb20a.
Here are the rebased patches.
I've divided the patch containing only cosmetic improvements into two
patches, of which the latter only moves around code. Patch 0003
implements the actual fix to the problem with multiway joins.
Thanks,
Amit
Attachment | Content-Type | Size |
---|---|---|
0001-Some-cosmetic-improvements-to-partitionwise-join-cod.patch | application/octet-stream | 12.9 KB |
0002-Move-some-code-from-joinrel.c-to-relnode.c.patch | application/octet-stream | 12.0 KB |
0003-Fix-partitionwise-join-to-handle-FULL-JOINs-correctl.patch | application/octet-stream | 13.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2019-11-06 09:40:14 | Re: Checking return value of SPI_execute |
Previous Message | Amit Kapila | 2019-11-06 09:34:20 | Re: define bool in pgtypeslib_extern.h |