From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, amitdkhan(dot)pg(at)gmail(dot)com |
Subject: | Re: partition routing layering in nodeModifyTable.c |
Date: | 2019-08-07 07:27:41 |
Message-ID: | CA+HiwqEC2co-5R3wpgnWx0_sDdVDPhb_fuuBBSHDcPC9Hb4Gvg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 7, 2019 at 12:00 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> IIUC, I think we reached a consensus at least on the 0001 patch.
> Andres, would you mind if I commit that patch?
I just noticed obsolete references to es_result_relation_info that
0002 failed to remove. One of them is in fdwhandler.sgml:
<programlisting>
TupleTableSlot *
IterateDirectModify(ForeignScanState *node);
</programlisting>
... The data that was actually inserted, updated
or deleted must be stored in the
<literal>es_result_relation_info->ri_projectReturning->pi_exprContext->ecxt_scantuple</literal>
of the node's <structname>EState</structname>.
We will need to rewrite this without mentioning
es_result_relation_info. How about as follows:
- <literal>es_result_relation_info->ri_projectReturning->pi_exprContext->ecxt_scantuple</literal>
- of the node's <structname>EState</structname>.
+ <literal>ri_projectReturning->pi_exprContext->ecxt_scantuple</literal>
+ of the result relation's<structname>ResultRelInfo</structname> that has
+ been made available via node.
I've updated 0001 with the above change.
Also, I updated 0002 to remove other references.
Thanks,
Amit
Attachment | Content-Type | Size |
---|---|---|
v6-0001-Revise-BeginDirectModify-API-to-pass-ResultRelInf.patch | application/octet-stream | 11.6 KB |
v6-0002-Remove-es_result_relation_info.patch | application/octet-stream | 37.9 KB |
v6-0004-Refactor-transition-tuple-capture-code-a-bit.patch | application/octet-stream | 20.8 KB |
v6-0003-Rearrange-partition-update-row-movement-code-a-bi.patch | application/octet-stream | 16.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kuntal Ghosh | 2019-08-07 07:41:51 | Re: POC: Cleaning up orphaned files using undo logs |
Previous Message | Konstantin Knizhnik | 2019-08-07 07:24:17 | Handling RestrictInfo in expression_tree_walker |