| From: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
|---|---|
| To: | Erik Wienhold <ewie(at)ewie(dot)name> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Patch: Add parse_type Function |
| Date: | 2024-02-20 03:06:13 |
| Message-ID: | B13EBBAB-AE1A-42AA-B5E9-EB05CA4EA47E@justatheory.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Feb 19, 2024, at 21:58, Erik Wienhold <ewie(at)ewie(dot)name> wrote:
> See the patch I wrote for my benchmarks. But it's pretty easy anyway to
> cut down parse_type() ;)
LOL, I missed that, just wrote it myself in the last hour. :-) v6 attached.
> But you don't actually need reformat_type() in pgTAP. You can just get
> the type OID and modifier of the want_type and have_type and compare
> those. Then use format_type() for the error message. Looks a bit
> cleaner to me than doing the string comparison.
Fair.
> On second thought, I guess comparing the reformatted type names is
> necessary in order to have a uniform API on older Postgres releases
> where pgTAP has to provide its own to_regtypmod() based on typmodin
> functions.
Maybe. Worth playing with.
>> For the latter, it could easily be an example in the docs.
>
> Can be mentioned right under format_type().
Well I included it in the to_regtypemod docs here, but could so either.
Best,
David
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-to_regtypemod-SQL-function.patch | application/octet-stream | 8.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-02-20 03:18:23 | Re: POC, WIP: OR-clause support for indexes |
| Previous Message | Erik Wienhold | 2024-02-20 02:58:05 | Re: Patch: Add parse_type Function |