Re: Patch bug: Fix jsonpath .* on Arrays

From: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Stepan Neretin <sncfmgg(at)gmail(dot)com>, Степан Неретин <fenixrnd(at)mail(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Subject: Re: Patch bug: Fix jsonpath .* on Arrays
Date: 2024-06-27 15:05:31
Message-ID: A8CDEEF9-DBA9-46DD-8055-9840EBE4AB65@justatheory.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jun 27, 2024, at 04:17, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> The tests of jsonb_jsonpath.sql include a lot of patterns for @? and
> jsonb_path_query with the lax and strict modes, so shouldn't these
> additions be grouped closer to the existing tests rather than added at
> the end of the file?

I think you could argue that they should go with other tests for array unwrapping, though it’s kind of mixed throughout. But that’s more the bit I was testing; almost all the tests are lax, and it’s less the strict behavior to test here than the explicit behavior of unwrapping in lax mode.

But ultimately I don’t care where they go, just that we have them.

D

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-06-27 15:06:27 Re: Custom type's modifiers
Previous Message Marthin Laubscher 2024-06-27 14:33:34 Custom type's modifiers