| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, "'Amit Langote'" <amitlangote09(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Subject: | Re: speeding up planning with partitions |
| Date: | 2019-03-19 06:53:19 |
| Message-ID: | 9feacaf6-ddb3-96dd-5b98-df5e927b1439@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Imai-san,
On 2019/03/15 9:33, Imai, Yoshikazu wrote:
> On Thu, Mar 14, 2019 at 9:04 AM, Amit Langote wrote:
>>> * In inheritance_planner(), we do ChangeVarNodes() only for orig_rtable,
>> so the codes concatenating lists of append_rel_list may be able to be
>> moved before doing ChangeVarNodes() and then the codes concatenating
>> lists of rowmarks, rtable and append_rel_list can be in one block (or
>> one bunch).
>>
>> Yeah, perhaps. I'll check.
I'm inclined to add source_appinfos to subroot->append_rel_list after
finishing the ChangeVarNodes(subroot->append_rel_list) step, because if
there are many entries in source_appinfos that would unnecessarily make
ChangeVarNodes take longer.
>> On 2019/03/14 17:35, Imai, Yoshikazu wrote:> Amit-san,
>>> I have done code review of v31 patches from 0004 to 0008.
>>>
>>> 0004:
>>> * s/childern/children
>>
>> Will fix.
Fixed.
I've attached updated patches. In the new version, I've moved some code
from 0004 to 0005 patch, so as to avoid mixing unrelated modifications in
one patch. Especially, orig_rtable now only appears after applying 0005.
I appreciate your continued interest in these patches.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| v32-0001-Build-other-rels-of-appendrel-baserels-in-a-sepa.patch | text/plain | 11.8 KB |
| v32-0002-Add-rowmark-junk-targetlist-entries-in-query_pla.patch | text/plain | 25.6 KB |
| v32-0003-Delay-adding-inheritance-child-tables-until-quer.patch | text/plain | 30.5 KB |
| v32-0004-Adjust-inheritance_planner-to-reuse-source-child.patch | text/plain | 26.8 KB |
| v32-0005-Further-tweak-inheritance_planner-to-avoid-usele.patch | text/plain | 4.7 KB |
| v32-0006-Perform-pruning-in-expand_partitioned_rtentry.patch | text/plain | 30.0 KB |
| v32-0007-Teach-planner-to-only-process-unpruned-partition.patch | text/plain | 7.6 KB |
| v32-0008-Don-t-copy-PartitionBoundInfo-in-set_relation_pa.patch | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2019-03-19 06:55:30 | Re: pg_upgrade version checking questions |
| Previous Message | Bruce Momjian | 2019-03-19 06:43:49 | Re: pg_upgrade version checking questions |