| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Cc: | "rjuju123(at)gmail(dot)com" <rjuju123(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de> |
| Subject: | Re: [PATCH] Expose port->authn_id to extensions and triggers |
| Date: | 2022-03-01 22:03:20 |
| Message-ID: | 9f9cde9f5f9b9ffc63a2c45c735e4129f19c8a42.camel@vmware.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2022-03-01 at 08:35 -0500, Stephen Frost wrote:
> * Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> >
> > Ayway, this function needs to be documented. I think that you should
> > just add that in "Session Information Functions" in func.sgml, same
> > area as current_user(). The last time we talked about the authn ID,
> > one thing we discussed about was how to describe that in a good way to
> > the user, which is why the section of log_connections was reworked a
> > bit. And we don't have yet any references to what an authenticated
> > identity is in the docs.
>
> Agreed that it should be documented and that location seems reasonable
> to me.
Added a first draft in v5, alongside the perltidy fixups mentioned by
Michael.
> > There is no need to update catversion.h in the patch, committers
> > usually take care of that and that's an area of the code that
> > conflicts a lot.
>
> Yeah, best to let committers handle catversion bumps.
Heh, that was added for my benefit -- I was tired of forgetting to
initdb after switching dev branches -- but I've dropped it from the
patch and will just carry that diff locally.
Thanks,
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-API-to-retrieve-authn_id-from-SQL.patch | text/x-patch | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-03-01 22:05:37 | Re: [PATCH] Expose port->authn_id to extensions and triggers |
| Previous Message | Andres Freund | 2022-03-01 21:58:48 | Re: Checkpointer sync queue fills up / loops around pg_usleep() are bad |