Re: [PoC] Federated Authn/z with OAUTHBEARER

Thanks for the updated version, it's really starting to take good shape. A few
small comments on v37 from a a first quick skim-through:

+ if (!strcmp(key, AUTH_KEY))
+ if (*expected_bearer && !strcmp(token, expected_bearer))
Nitpickery but these should be (strcmp(xxx) == 0) to match project style.
(ironically, the only !strcmp in the code was my mistake in ebc8b7d4416).

+ foreach(l, elemlist)
This one seems like a good candidate for a foreach_ptr construction.

+ *output = strdup(kvsep);
There is no check to ensure strdup worked AFAICT, and even though it's quite
unlikely to fail we definitely don't want to continue if it did.

fail_validator.c seems to have the #include list copied from validator.c and
pulls in unnecessarily many headers.

+ client's dummy reponse, and issues a FATAL error to end the exchange.
s/reponse/response/

In validate() I wonder if we should doublecheck that have a a proper set of
validator callbacks loaded just to make even more sure that we don't introduce
anything terrible in this codepath.

I will keep reviewing this version to try and provide more feedback.

--
Daniel Gustafsson