| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
| Date: | 2017-09-08 17:05:14 |
| Message-ID: | 92B0A7CD-B1A8-4EB6-A30F-2E3E1A206A24@amazon.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/8/17, 1:27 AM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
> Thanks. This looks now correct to me. Except that:
> + ereport(ERROR,
> + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> + errmsg("column lists cannot have duplicate entries"),
> + errhint("the column list specified for relation
> \"%s\" contains duplicates",
> + relation->relation->relname)));
> This should use ERRCODE_DUPLICATE_COLUMN.
Absolutely. This is fixed in v3.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| error_on_duplicate_columns_in_analyze_v3.patch | application/octet-stream | 5.9 KB |
| vacuum_multiple_tables_v15.patch | application/octet-stream | 31.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-09-08 17:06:10 | Re: The case for removing replacement selection sort |
| Previous Message | Peter Eisentraut | 2017-09-08 16:38:17 | Re: code cleanup empty string initializations |