From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
---|---|
To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: WIP: BRIN multi-range indexes |
Date: | 2021-02-15 14:37:01 |
Message-ID: | 906b4146-ceb2-e2ca-9689-840b2fca069f@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2/11/21 3:51 PM, Tomas Vondra wrote:
>
> ...
>
> This passes all my tests, including valgrind on the 32-bit rpi4 machine,
> the stress test (testing both the bloom and multi-minmax opclasses etc.)
>
OK, the cfbot seems happy with it, but I forgot to address the minor
issues mentioned in the review from 2021/02/09, so here's a patch series
addressing that.
Overall, I think the plan is to eventually commit 0001-0004 as is,
squash 0005-0007 (so the minmax-multi uses the "hybrid" approach). I
don't intend to commit 0008, because I have doubts those opclasses are
really useful for anything.
As for 0009, I think it's a fairly small tweak - the correlation made
sense for regular brin indexes, but those new oclasses are meant exactly
for cases where the data is not well correlated.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
0001-Pass-all-scan-keys-to-BRIN-consistent-funct-20210215.patch | text/x-patch | 23.5 KB |
0002-Move-IS-NOT-NULL-handling-from-BRIN-support-20210215.patch | text/x-patch | 23.3 KB |
0003-Optimize-allocations-in-bringetbitmap-20210215.patch | text/x-patch | 4.4 KB |
0004-BRIN-bloom-indexes-20210215.patch | text/x-patch | 127.4 KB |
0005-BRIN-minmax-multi-indexes-20210215.patch | text/x-patch | 224.9 KB |
0006-Batch-mode-when-building-new-BRIN-multi-min-20210215.patch | text/x-patch | 12.0 KB |
0007-Remove-the-special-batch-mode-use-a-larger--20210215.patch | text/x-patch | 39.4 KB |
0008-Define-multi-minmax-oclasses-for-types-with-20210215.patch | text/x-patch | 26.0 KB |
0009-Ignore-correlation-for-new-BRIN-opclasses-20210215.patch | text/x-patch | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Joel Jacobson | 2021-02-15 15:34:43 | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
Previous Message | Matthias van de Meent | 2021-02-15 14:28:23 | Re: SSL SNI |