From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
---|---|
To: | Vik Fearing <vik(at)postgresfriends(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Add XMLText function (SQL/XML X038) |
Date: | 2023-08-25 12:42:35 |
Message-ID: | 8d393cb8-93b7-4f8c-0a84-dfaab012a9b4@uni-muenster.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Vik
Thanks for reviewing my patch!
On 25.08.23 12:05, Vik Fearing wrote:
> I am replying to this email, but my comments are based on the v2 patch.
>
> Thank you for working on this, and I think this is a valuable
> addition. However, I have two issues with it.
>
> 1) There seems to be several spurious blank lines added that I do not
> think are warranted.
I tried to copy the aesthetics of other functions, but it seems I failed
:) I removed a few blank lines. I hope it's fine now.
Is there any tool like pgindent to take care of it automatically?
>
> 2) This patch does nothing to address the <XML returning clause> so we
> can't claim to implement X038 without a disclaimer. Upon further
> review, the same is true of XMLCOMMENT() so maybe that is okay for
> this patch, and a more comprehensive patch for our xml features is
> necessary.
If we decide to not address this point here, I can take a look at it and
work in a separated patch.
v3 attached.
Thanks
Jim
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Add-XMLText-function-SQL-XML-X038.patch | text/x-patch | 8.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-08-25 12:44:50 | Re: [PATCH] Add XMLText function (SQL/XML X038) |
Previous Message | Daniel Gustafsson | 2023-08-25 12:32:56 | Re: list of acknowledgments for PG16 |