| From: | bt22kawamotok <bt22kawamotok(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: is_superuser is not documented |
| Date: | 2022-09-12 08:13:34 |
| Message-ID: | 8838a06e69f2e30f38042bb9adc5755c@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On the other hand, it seems pretty silly that it's GUC_REPORT if
> we want to consider it private. I've not checked the git history,
> but I bet that flag was added later with no thought about context.
>
> If we are going to document this then we should at least remove
> the GUC_NO_SHOW_ALL flag and rewrite the comment. I wonder whether
> the GUC_NO_RESET_ALL flag is needed either --- seems like the
> PGC_INTERNAL context protects it sufficiently.
> I wonder why this one is marked USERSET where the other is not.
> You'd think both of them need similar special-casing about how
> to handle SET.
Thanks for your review.
I have created a patch in response to your suggestion.
I wasn't sure about USERSET, so I only created documentation for
is_superuser.
Regards,
Kotaro Kawamoto.
| Attachment | Content-Type | Size |
|---|---|---|
| add_document_is_superuser.patch | text/x-diff | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hamid Akhtar | 2022-09-12 08:15:18 | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |
| Previous Message | Shinya Kato | 2022-09-12 08:03:25 | Re: [PATCH]Feature improvement for MERGE tab completion |