| From: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: logical copy_replication_slot issues |
| Date: | 2020-03-06 11:02:53 |
| Message-ID: | 87imjh7nky.fsf@ars-thinkpad |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> It looks good to me now.
After lying for some time in my head it reminded me that
CreateInitDecodingContext not only pegs the LSN, but also xmin, so
attached makes a minor comment correction.
While taking a look at the nearby code it seemed weird to me that
GetOldestSafeDecodingTransactionId checks PGXACT->xid, not xmin. Don't
want to investigate this at the moment though, and not for this thread.
Also not for this thread, but I've noticed
pg_copy_logical_replication_slot doesn't allow to change plugin name
which is an omission in my view. It would be useful and trivial to do.
-- cheers, arseny
| Attachment | Content-Type | Size |
|---|---|---|
| fix_copy_slot_v4.patch | text/x-diff | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-03-06 11:46:51 | Re: [PATCH] Erase the distinctClause if the result is unique by definition |
| Previous Message | Fujii Masao | 2020-03-06 09:51:55 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |