From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Suraj Khamkar <khamkarsuraj(dot)b(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Tab completion for CREATE SCHEMAAUTHORIZATION |
Date: | 2023-04-14 16:04:35 |
Message-ID: | 87ildyqwks.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Aug 11, 2021 at 10:16:15AM +0900, Michael Paquier wrote:
>> + else if (Matches("CREATE", "SCHEMA", "AUTHORIZATION"))
>> + COMPLETE_WITH_QUERY(Query_for_list_of_owner_roles);
>> + else if (Matches("CREATE", "SCHEMA", MatchAny, "AUTHORIZATION"))
>> + COMPLETE_WITH_QUERY(Query_for_list_of_owner_roles);
>> + else if (Matches("CREATE", "SCHEMA", MatchAny, "AUTHORIZATION", MatchAny))
>> + COMPLETE_WITH("CREATE", "GRANT");
>> + else if (Matches("CREATE", "SCHEMA", MatchAny))
>> + COMPLETE_WITH("AUTHORIZATION", "CREATE", "GRANT");
>> Looks like you forgot the case "CREATE SCHEMA AUTHORIZATION MatchAny"
>> that should be completed by GRANT and CREATE.
>
> This patch has been waiting on author for more than a couple of weeks,
> so I have marked it as returned with feedback in the CF app. Please
> feel free to resubmit if you are able to work more on that.
Looks like I completely dropped the ball on this one, sorry. Here's a
rebased patch which uses the new COMPLETE_WITH_QUERY_PLUS functionality
added in commit 02b8048ba5dc36238f3e7c3c58c5946220298d71.
- ilmari
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Add-tab-completion-for-CREATE-SCHEMA.patch | text/x-diff | 2.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-04-14 16:06:07 | Re: [RFC] building postgres with meson -v8 |
Previous Message | Greg Stark | 2023-04-14 15:58:42 | Re: [RFC] building postgres with meson -v8 |