From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Move OpenSSL random under USE_OPENSSL_RANDOM |
Date: | 2020-11-17 20:24:30 |
Message-ID: | 835E868F-66A1-42BC-8A50-D19B57BA67A7@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 16 Nov 2020, at 16:06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> I agree with those -- either we remove the ability to choose random source
>> independently of the SSL library (and then only use the windows crypto
>> provider or /dev/urandom as platform-specific choices when *no* SSL library
>> is used), and in that case we should not have separate #ifdef's for them.
>> Or we fix the includes. Which is obviously easier, but we should take the
>> time to do what we think is right long-term of course.
>
> FWIW, I'd vote for the former. I think the presumption that OpenSSL's
> random-number machinery can be used without any other initialization is
> shaky as heck.
I tend to agree, randomness is complicated enough without adding a compile time
extensibility which few (if anyone) will ever use. Attached is an attempt at
this.
cheers ./daniel
Attachment | Content-Type | Size |
---|---|---|
0001-Remove-ability-to-choose-randomness-source.patch | application/octet-stream | 8.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Chapman Flack | 2020-11-17 20:45:11 | Re: pl/pgsql feature request: shorthand for argument and local variable references |
Previous Message | Jack Christensen | 2020-11-17 20:18:51 | Re: pl/pgsql feature request: shorthand for argument and local variable references |