From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Hubert Zhang <zhubert(at)vmware(dot)com> |
Cc: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Multiple hosts in connection string failed to failover in non-hot standby mode |
Date: | 2021-01-11 02:56:34 |
Message-ID: | 810463.1610333794@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> I feel pretty good about 0001: it might be committable as-is. 0002 is
> probably subject to bikeshedding, plus it has a problem in the ECPG tests.
> Two of the error messages are now unstable because they expose
> chosen-at-random socket paths:
> ...
> I don't have any non-hacky ideas what to do about that. The extra detail
> seems useful to end users, but we don't have any infrastructure that
> would allow filtering it out in the ECPG tests.
So far the only solution that comes to mind is to introduce some
infrastructure to do that filtering. 0001-0003 below are unchanged,
0004 patches up the ecpg test framework with a rather ad-hoc filtering
function. I'd feel worse about this if there weren't already a very
ad-hoc filtering function there ;-)
This set passes check-world for me; we'll soon see what the cfbot
thinks.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
0001-append-all-error-messages.patch | text/x-diff | 127.2 KB |
0002-identify-host-more-consistently-wip.patch | text/x-diff | 8.8 KB |
0003-retry-if-cannot-connect-now.patch | text/x-diff | 964 bytes |
0004-fix-unstable-ecpg-tests.patch | text/x-diff | 11.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2021-01-11 02:59:42 | Re: pg_preadv() and pg_pwritev() |
Previous Message | Tatsuo Ishii | 2021-01-11 02:39:20 | Re: Inconsistent "<acronym>" use |