Re: AIO v2.5

From: Andres Freund <andres(at)anarazel(dot)de>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Antonin Houska <ah(at)cybertec(dot)at>
Subject: Re: AIO v2.5
Date: 2025-04-01 00:41:39
Message-ID: 7s6fclfekpcxoaaorwrq67v4vmgixf2dcjcgznuj7vxs3ie3wq@okqbi5vabqbx
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-03-30 19:46:57 -0400, Andres Freund wrote:
> I didn't yet push
>
> > > Subject: [PATCH v2.14 13/29] aio: Add README.md explaining higher level design
>
> because I want to integrate some language that could be referenced by
> smgrstartreadv() (and more in the future), as we have been talking about.

I tried a bunch of variations and none of them seemed great. So I ended up
with a lightly polished version of your suggested comment above
smgrstartreadv(). We can later see about generalizing it.

> Tomorrow I'll work on sending out a new version with the remaining patches. I
> plan for that version to have:

Got a bit distracted with $work stuff today, but here we go.

The updated version has all of that:

> - pg_aios view with the security checks (already done, trivial)
>
> - a commit with updated language for smgrstartreadv(), probably referencing
> aio's README
>
> - a change to mdreadv() around zero_damaged_pages, as Noah and I have been
> discussing
>
> - updated tests, with the FIXMEs etc addressed
>
> - a reviewed version of the errcontext callback patch that Melanie sent
> earlier today

Although I didn't actually find anything in that, other than one unnecessary
change.

Greetings,

Andres Freund

Attachment Content-Type Size
v2.15-0001-docs-Add-acronym-and-glossary-entries-for-I-O-.patch text/x-diff 3.5 KB
v2.15-0002-aio-Add-pg_aios-view.patch text/x-diff 22.6 KB
v2.15-0003-aio-Add-README.md-explaining-higher-level-desi.patch text/x-diff 19.1 KB
v2.15-0004-aio-Add-test_aio-module.patch text/x-diff 77.5 KB
v2.15-0005-md-Add-comment-assert-to-buffer-zeroing-path-i.patch text/x-diff 4.5 KB
v2.15-0006-aio-comment-polishing.patch text/x-diff 2.1 KB
v2.15-0007-aio-Add-errcontext-for-processing-I-Os-for-ano.patch text/x-diff 4.8 KB
v2.15-0008-aio-Experimental-heuristics-to-increase-batchi.patch text/x-diff 1.6 KB
v2.15-0009-aio-Implement-smgr-md-fd-write-support.patch text/x-diff 14.5 KB
v2.15-0010-aio-Add-bounce-buffers.patch text/x-diff 23.2 KB
v2.15-0011-bufmgr-Implement-AIO-write-support.patch text/x-diff 11.9 KB
v2.15-0012-aio-Add-IO-queue-helper.patch text/x-diff 7.4 KB
v2.15-0013-bufmgr-use-AIO-in-checkpointer-bgwriter.patch text/x-diff 31.6 KB
v2.15-0014-Ensure-a-resowner-exists-for-all-paths-that-ma.patch text/x-diff 2.6 KB
v2.15-0015-Temporary-Increase-BAS_BULKREAD-size.patch text/x-diff 1.3 KB
v2.15-0016-WIP-Use-MAP_POPULATE.patch text/x-diff 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2025-04-01 00:48:24 Re: pgsql: Add memory/disk usage for Window aggregate nodes in EXPLAIN.
Previous Message Jacob Champion 2025-04-01 00:06:16 Re: pgsql: Add support for OAUTHBEARER SASL mechanism