[BUG FIX]: invalid meson version detection

From: Sergey Solovev <sergey(dot)soloviev(at)tantorlabs(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [BUG FIX]: invalid meson version detection
Date: 2024-08-14 14:02:05
Message-ID: 7e0963e9-8775-46d9-b76f-6392474cb609@tantorlabs.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi.

I looked at meson.build file at found an incorrectly used function to

determine postgres version.

> if pg_version.endswith('devel')
>   pg_version_arr = [pg_version.split('devel')[0], '0']

There should be `pg_version.contains('devel')`, not `endswith`. Like this:

-if pg_version.endswith('devel')
+if pg_version.contains('devel')

Next statement seems to be valid:

>elif pg_version.contains('beta')
>  pg_version_arr = [pg_version.split('beta')[0], '0']
>elif pg_version.contains('rc')
>  pg_version_arr = [pg_version.split('rc')[0], '0']
>else
>  pg_version_arr = pg_version.split('.')
>endif

I created a single line patch for it.

Attachment Content-Type Size
0001-Invalid-version-string-split-in-meson.patch text/x-patch 707 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michail Nikolaev 2024-08-14 14:15:10 Re: Conflict detection and logging in logical replication
Previous Message Arseny Sher 2024-08-14 13:54:52 Re: Taking into account syncrep position in flush_lsn reported by apply worker