From: | Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Subject: | Re: [PATCH] Completed unaccent dictionary with many missing characters |
Date: | 2022-07-03 20:51:56 |
Message-ID: | 7b7b7907-4174-8014-eb89-396759f46d8d@sztoch.pl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier wrote on 6/28/2022 7:14 AM:
> On Thu, Jun 23, 2022 at 02:10:42PM +0200, Przemysław Sztoch wrote:
>> The only division that is probably possible is the one attached.
> Well, the addition of cyrillic does not make necessary the removal of
> SOUND RECORDING COPYRIGHT or the DEGREEs, that implies the use of a
> dictionnary when manipulating the set of codepoints, but that's me
> being too picky. Just to say that I am fine with what you are
> proposing here.
>
> By the way, could you add a couple of regressions tests for each
> patch with a sample of the characters added? U+210C is a particularly
> sensitive case, as we should really make sure that it maps to what we
> want even if Latin-ASCII.xml tells a different story. This requires
> the addition of a couple of queries in unaccent.sql with the expected
> output updated in unaccent.out.
> --
> Michael
Regression tests has been added.
--
Przemysław Sztoch | Mobile +48 509 99 00 66
Attachment | Content-Type | Size |
---|---|---|
0001-Update-unnaccent-rules-generator-v5.patch | text/plain | 19.2 KB |
0002-Unaccent-More-characters-category-v5.patch | text/plain | 8.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-07-03 21:28:22 | Re: [PoC] Reducing planning time when tables have many partitions |
Previous Message | Tom Lane | 2022-07-03 20:50:44 | Re: Allow makeaclitem() to accept multiple privileges |