Re: libpq compression

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Daniil Zakhlystov <usernamedt(at)yandex-team(dot)ru>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, ianzag(at)gmail(dot)com
Subject: Re: libpq compression
Date: 2021-10-01 21:20:09
Message-ID: 78AB87C8-297A-42C5-98D7-17C44F2FBE49@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 2 Sep 2021, at 00:29, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 29 Jul 2021, at 16:57, Daniil Zakhlystov <usernamedt(at)yandex-team(dot)ru> wrote:
>>
>> Forgot to attach the updated patch :)
>
> This fails to build on Windows due to the use of strcasecmp:
>
> + if (strcasecmp(supported_algorithms[zpq->compressors[i].impl], "zstd") ==
>
> Was that meant to be pg_strcasecmp?

To keep this thread from stalling, attached is a rebased patchset with the
above mentioned fix to try and get this working on Windows.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
0001-Add-zlib-and-zstd-streaming-compression.patch application/octet-stream 24.7 KB
0002-Implement-libpq-compression.patch application/octet-stream 119.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-10-01 21:21:04 Re: parallelizing the archiver
Previous Message Daniel Gustafsson 2021-10-01 20:58:07 Re: Memory leak in pg_hmac_final