Re: [PoC] Reducing planning time when tables have many partitions

From: Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Yuya Watari <watari(dot)yuya(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Lepikhov Andrei <a(dot)lepikhov(at)postgrespro(dot)ru>, David Rowley <dgrowleyml(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Zhang Mingli <zmlpostgres(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PoC] Reducing planning time when tables have many partitions
Date: 2023-11-18 23:57:34
Message-ID: 72d292a1-06ff-432a-a803-af5053786444@yandex.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18.11.2023 05:45, John Naylor wrote:
> On Sat, Nov 18, 2023 at 4:04 AM Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> wrote:
>> All diff files have already been added to v21-0002-Introduce-indexes-for-RestrictInfo patch.
> Unfortunately, the patch tester is too smart for its own good, and
> will try to apply .diff files as well. Since
> bug_related_to_atomic_function.diff is first in the alphabet, it comes
> first, which is the reason for the current CI failure.

On 18.11.2023 06:13, Tom Lane wrote:
> John Naylor <johncnaylorls(at)gmail(dot)com> writes:
>> On Sat, Nov 18, 2023 at 4:04 AM Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> wrote:
>>> All diff files have already been added to v21-0002-Introduce-indexes-for-RestrictInfo patch.
>> Unfortunately, the patch tester is too smart for its own good, and
>> will try to apply .diff files as well.
> Yeah --- see documentation here:
>
> https://wiki.postgresql.org/wiki/Cfbot
>
> That suggests using a .txt extension for anything you don't want to
> be taken as part of the patch set.
>
> regards, tom lane

Thank you for explanation. I fixed it.

I have attached the previous diff files as txt so that they will not
applied (they are already applied in the second patch
"v21-0002-PATCH-PATCH-1-2-Introduce-indexes-for-RestrictInfo-T.patch").
Also, the previous time I missed the fact that the files conflict with
each other - I fixed it too and everything seems to work fine now.

Attachment Content-Type Size
v21-0001-PATCH-PATCH-1-2-Speed-up-searches-for-child-Equivale.patch text/x-patch 61.4 KB
v21-0002-PATCH-PATCH-1-2-Introduce-indexes-for-RestrictInfo-T.patch text/x-patch 36.7 KB
bug_related_to_atomic_function.txt text/plain 2.3 KB
solved_conflict_with_self_join_removal.txt text/plain 8.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-11-19 00:04:16 Re: Relation bulk write facility
Previous Message Andres Freund 2023-11-18 23:09:58 reindexing an invalid index should not use ERRCODE_INDEX_CORRUPTED