Re: psql \copy from sends a lot of packets

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: psql \copy from sends a lot of packets
Date: 2021-07-14 10:11:59
Message-ID: 72af2829-a003-3973-3aef-adcea9169816@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13/07/2021 14:52, Aleksander Alekseev wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> The patch was marked as the one that needs review and doesn't currently have
> a reviewer, so I decided to take a look. The patch was tested on MacOS against
> master `e0271d5f`. It works fine and doesn't seem to contradict the current
> documentation.

Thanks for the review! I read through it myself one more time and
spotted one bug: in interactive mode, the prompt was printed twice in
the beginning of the operation. Fixed that, and pushed.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-07-14 10:13:45 Re: [PATCH] Use optimized single-datum tuplesort in ExecSort
Previous Message Tomas Vondra 2021-07-14 10:08:01 Re: proposal: possibility to read dumped table's name from file