| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-01-25 20:07:04 |
| Message-ID: | 6db39a5e-67ab-495d-9dfb-38b596df0d58@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/01/2024 18:17, Robert Haas wrote:
> I think we should try to pick prefixes that are one or more words
> rather than using word fragments. bulkw is an awkward prefix even for
> people whose first language is English, and probably more awkward for
> others.
Renamed the 'bulkw' variables to 'bulkstate, and the functions to have
smgr_bulk_* prefix.
I was tempted to use just bulk_* as the prefix, but I'm afraid e.g.
bulk_write() is too generic.
On 22/01/2024 07:50, Peter Smith wrote:
> Hi, This patch has a CF status of "Needs Review" [1], but it seems
> there was a CFbot test failure last time it was run [2]. Please have a
> look and post an updated version if necessary.
Fixed the headerscheck failure by adding appropriate #includes.
--
Heikki Linnakangas
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Introduce-a-new-bulk-loading-facility.patch | text/x-patch | 54.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2024-01-25 20:25:28 | Re: More new SQL/JSON item methods |
| Previous Message | Andrew Dunstan | 2024-01-25 19:41:07 | Re: More new SQL/JSON item methods |