From: | Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, przemyslaw(at)sztoch(dot)pl, david(dot)g(dot)johnston(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, daniel(at)yesql(dot)se, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add --{no-,}bypassrls flags to createuser |
Date: | 2022-05-26 05:16:37 |
Message-ID: | 6a25c0fec85c61c0bb93ab4819fdd619@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2022-05-25 12:47, Michael Paquier wrote:
> On Wed, May 25, 2022 at 11:07:52AM +0900, Kyotaro Horiguchi wrote:
>> I reproduced the same failure at my hand and identified the
>> cause. Windows' version of getopt_long seems to dislike that
>> non-optional parameters precedes options.
>
> Tweaking the list of arguments in some commands kicked by the TAP
> tests to satisfy our implementation of getopt_long() has been the
> origin of a couple of portability fixes, like ffd3980.
Thanks! I fixed it.
On 2022-05-25 11:07, Kyotaro Horiguchi wrote:
> At Tue, 24 May 2022 10:09:10 -0700, Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote in
>> We're still missing some "fancier" string patterns in the tests, but
>> we
>> might just be nitpicking at this point.
>
> Such "fancier" strings should be properly handled by FmtId() and
> appendStringLiteralConn. If this is a privilege escalating command,
> we should have ones but this is not.
Sorry, I didn't quite understand the "fancier" pattern. Is a string like
this patch correct?
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
v9-0001-Add-missing-options-to-createuser.patch | text/x-diff | 10.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gurjeet Singh | 2022-05-26 05:24:08 | Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds |
Previous Message | Amit Kapila | 2022-05-26 05:08:42 | Re: Handle infinite recursion in logical replication setup |