| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Paul Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: SQL:2011 application time |
| Date: | 2024-12-10 14:40:40 |
| Message-ID: | 6a2247d9-461d-4b0a-b692-f0f3c0fab27f@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.12.24 20:29, Paul Jungwirth wrote:
> These five patches all look good to me.
>
> Note that my tests already include a section for REPLICA IDENTITY FULL,
> which passed. But the subscriber was using a SeqScan to look up tuples
> to update.
>
> Here are the steps (mostly just because it was confusing for me at
> first): First in FindUsableIndexForReplicaIdentityFull, we would call
> IsIndexUsableForReplicaIdentityFull, get back false, and decide there
> was no index to use. Then in FindReplTupleInLocalRel, localidxoid was 0,
> so we woudln't call IsIndexUsableForReplicaIdentityFull at all.
>
> After applying the five patches, I can see that we choose the index and
> call IsIndexUsableForReplicaIdentityFull from both sites. This should
> make applying changes a lot faster.
I have committed these. I will continue with reviewing v45-0002 and
following now.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-12-10 15:13:37 | Re: [PATCH] Support Int64 GUCs |
| Previous Message | jian he | 2024-12-10 14:38:41 | Re: Pass ParseState as down to utility functions. |