| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_amcheck contrib application |
| Date: | 2021-03-29 23:16:44 |
| Message-ID: | 6915B9B2-B551-4DBC-89DB-C12D9AF985B8@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 29, 2021, at 1:06 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> Hmm, so this got ~10x bigger from my version. Could you perhaps
> separate it out into a series of patches for easier review? Say, one
> that just fixes the visibility logic, and then a second to avoid doing
> the TOAST check with a buffer lock held, and then more than that if
> there are other pieces that make sense to separate out?
Sure, here are four patches which do the same as the single v12 patch did.
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-Refactoring-function-check_tuple_header_and_visi.patch | application/octet-stream | 7.7 KB |
| v13-0002-Replacing-implementation-of-check_tuple_visibili.patch | application/octet-stream | 21.3 KB |
| v13-0003-Renaming-report_corruption-as-report_main_corrup.patch | application/octet-stream | 32.8 KB |
| v13-0004-Checking-toast-separately-from-the-main-table.patch | application/octet-stream | 21.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Hilliard | 2021-03-29 23:31:51 | Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. |
| Previous Message | John Naylor | 2021-03-29 23:15:19 | Re: Add missing function abs (interval) |