From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: generating fmgr prototypes automatically |
Date: | 2017-01-04 20:09:35 |
Message-ID: | 67dae722-fe83-cde8-c279-903e39c4ac2e@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 1/3/17 2:16 PM, Pavel Stehule wrote:
> patch 0001 .. trivial cleaning
> patch 0002 .. renaming lo_* to be_lo_* -- the prefix "be" is not what I
> expect - maybe "pg" instead. More because the be-fsstubs.h will be
> holds only lo_read, lo_write on end
It's the naming that the OpenSSL functions use, e.g., be_tls_init.
> patch 0003 .. trivial, but doesn't mean so we have not regress tests for
> these functions?
OK, added tests.
> patch 0004 .. bigger part - I miss a comments when there are a exceptions:
>
> extern Datum numeric_float8_no_overflow(PG_FUNCTION_ARGS);
> extern Datum nextval(PG_FUNCTION_ARGS);
> extern Datum fmgr_sql(PG_FUNCTION_ARGS);
> extern Datum aggregate_dummy(PG_FUNCTION_ARGS);
These functions and their special purpose are commented in the .c files,
so I think that is covered OK. I added an additional comment to the
numeric_float8_no_overflow().
> I found some obsolete definitions in c files
OK, fixed those as well. I think I initially only looked in .h files.
That just underlines how inconsistent this is, e.g.,
> pgstatfuncs.c
>
> /* bogus ... these externs should be in a header file */
> namespace.c
>
> /* These don't really need to appear in any header file */
New patch set attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Remove-unnecessary-prototypes-in-loadable-modules.patch | text/x-patch | 1.7 KB |
v2-0002-Remove-unnecessary-include.patch | text/x-patch | 1.7 KB |
v2-0003-Rename-C-symbols-for-backend-lo_-functions.patch | text/x-patch | 16.4 KB |
v2-0004-Add-more-tests-for-money-type.patch | text/x-patch | 4.6 KB |
v2-0005-Register-missing-money-operators-in-system-catalo.patch | text/x-patch | 4.9 KB |
v2-0006-Generate-fmgr-prototypes-automatically.patch | text/x-patch | 177.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2017-01-04 20:10:45 | Re: pg_hba_file_settings view patch |
Previous Message | David Fetter | 2017-01-04 20:02:30 | Re: pgsql: Update copyright for 2017 |