From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <jchampion(at)timescale(dot)com>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |
Date: | 2024-01-17 14:37:53 |
Message-ID: | 6408F630-3533-4D98-B0FE-89D6AED5AB52@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
> On 21 Jul 2023, at 01:53, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jul 20, 2023 at 12:36:52PM +0200, Daniel Gustafsson wrote:
>> On 20 Jul 2023, at 09:47, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>> Hmm. Are you sure that this is correct for pg_rewind? This should
>>> work when using a local source with --source-pgdata, but under a
>>> remote source with --source-pgdata, I get the impression that we'd
>>> still copy a .DS_store into the target's data folder.
>>
>> Ah, good point. The updated patch should work for both by moving the check
>> into the filemap.
>
> Sounds OK to me to do that in the filemap. The checksum and base
> backup parts look OK as well. Thanks for the quick update!
Reviving an old thread which had fallen off the end of the TODO. The attached
is a rebase over nearby changes causing conflicts but no functional changes
from the previous which was marked ready for committer, so will go ahead with
this once it's been through a CI cycle in the cfbot.
--
Daniel Gustafsson
Attachment | Content-Type | Size |
---|---|---|
v8-0001-Skip-.DS_Store-files-in-server-side-utils.patch | application/octet-stream | 8.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tender Wang | 2024-01-17 15:03:56 | Re: BUG #18297: Error when adding a column to a parent table with complex inheritance |
Previous Message | Richard Guo | 2024-01-17 11:54:26 | Re: BUG #18297: Error when adding a column to a parent table with complex inheritance |