| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Logical replication existing data copy |
| Date: | 2017-03-24 14:09:38 |
| Message-ID: | 63e9613f-258b-8f49-42ea-58dafb6e9ba3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24/03/17 15:05, Peter Eisentraut wrote:
> On 3/23/17 19:32, Petr Jelinek wrote:
>> Yes, I also forgot to check if the table actually exists on subscriber
>> when fetching them in CREATE SUBSCRIPTION (we have check during
>> replication but not there).
>
> I think for this we can probably just change the missing_ok argument of
> RangeVarGetRelid() to false.
>
> Unless we want the custom error message, in which case we need to change
> AlterSubscription_refresh(), because right now it errors out because
> missing_ok = false.
>
You are right, stupid me.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Check-that-published-table-exists-on-subscriber.patch | text/x-patch | 907 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anastasia Lubennikova | 2017-03-24 14:11:22 | Re: pg_serial early wraparound |
| Previous Message | Simon Riggs | 2017-03-24 14:06:50 | Re: Declarative partitioning optimization for large amount of partitions |