Re: Minor code improvement to estimate_path_cost_size in postgres_fdw

From: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Minor code improvement to estimate_path_cost_size in postgres_fdw
Date: 2018-01-12 00:42:21
Message-ID: 61b91e36-9c9a-814c-c74e-26cfc6a4ae45@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018/01/12 1:54, Tom Lane wrote:
> Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> The declaration of estimate_path_cost_size uses baserel, but
>> the actual definition uses foreignrel. It would be better to sync.
>
> Yeah, the join_conds parameter's been renamed at some point too :-(
> Fixed.
>
> regards, tom lane

Thanks! :)

Regards,
Tatsuro Yamada

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-01-12 00:45:19 Re: [HACKERS] Cache lookup errors with functions manipulation object addresses
Previous Message Thomas Munro 2018-01-12 00:40:57 Re: [HACKERS] Cached plans and statement generalization