Re: [RFC] building postgres with meson -v7

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RFC] building postgres with meson -v7
Date: 2022-03-10 16:31:42
Message-ID: 616c6873-83b5-85c0-93cb-548977c39c60@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.03.22 17:44, Andres Freund wrote:
>> v6-0009-prereq-make-unicode-targets-work-in-vpath-builds.patch.gz
>>
>> Another directory issue
> I think it's a tad different, in that it's fixing something that's currently
> broken in VPATH builds.

Ok, I took another look at this.

-override CPPFLAGS := -DFRONTEND $(CPPFLAGS)
+override CPPFLAGS := -DFRONTEND
-I$(abs_top_builddir)/src/common/unicode $(CPPFLAGS)

This could just be

-I.

- $(PERL) generate-unicode_norm_table.pl
+ $(PERL) $< $(CURDIR)

I didn't detect a need for the additional directory argument. (So the
changes in generate-unicode_norm_table.pl are also apparently not
necessary.) Maybe this is something that will become useful later, in
which case it should be split out from this patch.

The rest of this patch looks ok.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2022-03-10 16:38:37 Re: pg_stat_statements and "IN" conditions
Previous Message Mark Dilger 2022-03-10 16:26:42 Re: role self-revocation