Re: AIO v2.0

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Pang <robertpang(at)google(dot)com>
Cc: 陈宗志 <baotiao(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: AIO v2.0
Date: 2024-09-16 17:56:09
Message-ID: 5izjdmmi5bvr5p7v5djoaqtykbyllf3nolt5npuvcd45pj2mds@cz3timgxtbpu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2024-09-12 14:55:49 -0700, Robert Pang wrote:
> Hi Andres
>
> Thanks for the AIO patch update. I gave it a try and ran into a FATAL
> in bgwriter when executing a benchmark.
>
> 2024-09-12 01:38:00.851 PDT [2780939] PANIC: no more bbs
> 2024-09-12 01:38:00.854 PDT [2780473] LOG: background writer process
> (PID 2780939) was terminated by signal 6: Aborted
> 2024-09-12 01:38:00.854 PDT [2780473] LOG: terminating any other
> active server processes
>
> I debugged a bit and found that BgBufferSync() is not capping the
> batch size under io_bounce_buffers like BufferSync() for checkpoint.
> Here is a small patch to fix it.

Good catch, thanks!

I am hoping (as described in my email to Noah a few minutes ago) that we can
get away from needing bounce buffers. They are a quite expensive solution to a
problem we made for ourselves...

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2024-09-16 18:15:34 Re: Detailed release notes
Previous Message Andres Freund 2024-09-16 17:51:42 Re: AIO v2.0