From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Consistently catch errors from Python _New() functions |
Date: | 2017-11-18 18:40:46 |
Message-ID: | 5ca74b8f-2c21-893b-d3e5-c819cb0c6f4d@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 11/18/17 12:05, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> On 11/17/17 12:16, Tom Lane wrote:
>>> I'm confused by the places that change PLy_elog calls to pass NULL:
>>>
>>> - PLy_elog(ERROR, "could not create globals");
>>> + PLy_elog(ERROR, NULL);
>>>
>>> How is that an improvement? Otherwise it looks reasonable.
>
>> If we pass NULL, then the current Python exception becomes the primary
>> error, so you'd end up with an "out of memory" error of some kind with a
>> stack trace, which seems useful.
>
> Oh, I see. Objection withdrawn.
Committed, thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2017-11-18 19:57:13 | spgist rangetypes compiler warning (gcc 7.2.0) |
Previous Message | Tom Lane | 2017-11-18 18:32:30 | Re: [HACKERS] Add Roman numeral conversion to to_number |