From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |
Date: | 2018-12-25 01:56:04 |
Message-ID: | 5be2c21a-9a15-8200-0c76-6bc936ef69f7@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2018/12/21 16:13, Michael Paquier wrote:
> On Fri, Dec 21, 2018 at 02:51:51PM +0900, Tatsuro Yamada wrote:
>> Attached file is a WIP patch.
>
> Before sorting out the exotic part of the feature, why not first fixing
> the simple cases where we know that tab completion is broken and can be
> improved? This is what I meant in this email:
> https://www.postgresql.org/message-id/20181219092255.GC680@paquier.xyz
>
> The attached patch implements the idea. What do you think?
Hmm... Okey, I agree.
Why I implemented the exotic part of the feature is that it is for user-friendly.
However, I suppose that user know the syntax because the syntax is used by an expert user.
Then, I got following messages when I patched your file on b981df4cc09aca978c5ce55e437a74913d09cccc,
so I rebased it. Please find attached file. :)
=======
$ patch -p1 < psql-tab-alter-column-stats-1.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/bin/psql/tab-complete.c
Hunk #1 succeeded at 1601 (offset 35 lines).
Hunk #2 succeeded at 1920 (offset 35 lines).
=======
Thanks,
Tatsuro Yamada
Attachment | Content-Type | Size |
---|---|---|
psql-tab-alter-column-stats-2.patch | text/x-patch | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Mitar | 2018-12-25 02:17:16 | Re: Feature: triggers on materialized views |
Previous Message | Alexander Korotkov | 2018-12-25 01:32:49 | Re: GIN predicate locking slows down valgrind isolationtests tremendously |